Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] use a block color handler #154

Open
octarine-noise opened this issue Jul 6, 2017 · 0 comments
Open

[Suggestion] use a block color handler #154

octarine-noise opened this issue Jul 6, 2017 · 0 comments

Comments

@octarine-noise
Copy link

Hi there, I'm the author of the Better Foliage mod, and I've recently got a request to support ExNihiloOmnia infested leaves.

It's a messy issue because of the custom renderer and the color handling (which I would obviously have to reproduce to make it look okay), so for the moment I've turned it down.

However, if I read your code correctly, it just renders a baked model, with a color multiplier that depends on the tint index. You could do that with a color handler (see BlockColors.registerColorHandler), which would simplify your code (no need for the special renderer), and also make it "just work" with BF.

Unless I've missed something in my analysis, would you consider making this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant