Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hilbert(S::Space{<:PeriodicLine},f,z) calls domain(f::AbstractVector) #152

Open
mjp98 opened this issue Jul 26, 2022 · 1 comment
Open

Comments

@mjp98
Copy link

mjp98 commented Jul 26, 2022

On line 14 of periodicline.jl there appears to be a typo, leading to a call to domain(f::AbstractVector) which is not defined.

function hilbert(S::Space{<:PeriodicLine},f::AbstractVector,z::Number)
    S2=setdomain(S,Circle())
    hilbert(S2,f,mappoint(domain(f),Circle(),z))-hilbert(S2,f,-1)
end

I think the last line should read hilbert(S2,f,mappoint(domain(S),Circle(),z))-hilbert(S2,f,-1)?

A similar issue occurs on line 24. I would be happy to put together a pull request to fix this.

@dlfivefifty
Copy link
Member

Great, thanks!

@mjp98 mjp98 changed the title hilbert(S::Space{<:PeriodicLine},f,z) calls domain(f::AbstractVector) hilbert(S::Space{<:PeriodicLine},f,z) calls domain(f::AbstractVector) Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants