Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FillArrays sometimes much slower than MappedArrays #134

Open
cscherrer opened this issue Feb 2, 2021 · 1 comment
Open

FillArrays sometimes much slower than MappedArrays #134

cscherrer opened this issue Feb 2, 2021 · 1 comment

Comments

@cscherrer
Copy link

Hi,

This issue came up here:
JuliaMath/MeasureTheory.jl#52

It's very surprising to me that the simpler representation used by FillArrays can sometimes be harder to optimize. I'm just posting here so you're aware this can sometimes be a problem.
@dlfivefifty
Copy link
Member

It seems like the issue is constant propagation failing. We could try adding @inline to the constructor, otherwise we'll have to consult a compiler expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cscherrer @dlfivefifty