Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Base.emptymutable #238

Open
andyferris opened this issue Jul 31, 2022 · 2 comments
Open

Support Base.emptymutable #238

andyferris opened this issue Jul 31, 2022 · 2 comments

Comments

@andyferris
Copy link
Member

I wonder if we could add support for Base.emptymutable in StructArrays? For arrays it behaves like similar but with guarantee that you can push!, etc to the output (while similar outputs must support setindex! but not necessarily resizing), and is used internally in various algorithms (and occassionally in the package ecosystem, e.g. xref JuliaData/SplitApplyCombine.jl#54).
This was referenced Jul 31, 2022
Open
Closed
@piever
Copy link
Collaborator

piever commented Aug 3, 2022

It makes sense to add it, but maybe it's best to wait to get some confirmation at JuliaLang/julia#46230 that it's actually a stable API?

@jishnub
Copy link
Member

jishnub commented Dec 15, 2023 •
edited
Loading

I've updated JuliaLang/julia#49958 to use similar in emptymutable. In that case, we won't need to extend it here.

Edit: emptymutable isn't added there anymore

@jishnub jishnub mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andyferris @piever @jishnub