Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burn.jl uses TimeZones.jl but TimeZones.jl may change behaviour #4

Closed
iamed2 opened this issue Mar 10, 2022 · 1 comment · Fixed by #20
Closed

burn.jl uses TimeZones.jl but TimeZones.jl may change behaviour #4

iamed2 opened this issue Mar 10, 2022 · 1 comment · Fixed by #20

Comments

@iamed2
Copy link
Member

iamed2 commented Mar 10, 2022

There may be some differences between the behaviour of the GC in the example as reported in JuliaLang/julia#40644 and as is now due to a couple of the fields becoming isbits. As ZonedDateTime might also change again in the future as well, it might be worth making a synthetic struct for testing in burn.jl instead of using ZonedDateTime.

@oscardssmith
Copy link
Collaborator

we could just pin the version, but making the synthetic benchmark is almost as easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants