Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3.head_object uses deprecated HEAD request form #581

Open
IanButterworth opened this issue Sep 26, 2022 · 8 comments
Open

S3.head_object uses deprecated HEAD request form #581

IanButterworth opened this issue Sep 26, 2022 · 8 comments

Comments

@IanButterworth
Copy link
Contributor

It was a bit of a pain to track this down because the depwarning doesn't give a correct location

┌ Warning: Using "HEAD" in AWS requests to return headers is deprecated, use `@service S3 use_response_type=true` to return an `AWS.Response` allowing for header access via `response.headers`.
│   caller = ip:0x0
└ @ Core :-1

But it turns out that S3.head_object uses a deprecated request form

"HEAD", "/$(Bucket)/$(Key)"; aws_config=aws_config, feature_set=SERVICE_FEATURE_SET

So the user can hit this without doing anything wrong AFAICT

@mattBrzezinski
Copy link
Member

mattBrzezinski commented Sep 27, 2022

That's a fun one, looks like there are three instances of using HTTP HEAD requests,

@IanButterworth
Copy link
Contributor Author

Is there a simple fix here? I'd love to not see the warning

@mattBrzezinski
Copy link
Member

The issue stems from here, I think @omus this can be removed? As we do another check in each of the XML, JSON, MIME if statements for returning back headers?

Longer-term wrapping up the remaining tasks for AWS@2, removing the deprecations fixes this problem.

@IanButterworth
Copy link
Contributor Author

friendly bump

@mattBrzezinski
Copy link
Member

I'm away on holidays for the remainder of the year essentially, this is quite a low priority issue and a proper fix is quite far away.

One suggestion if this is getting very annoying is to use Suppressor.jl which would work around this temporarily.

@IanButterworth
Copy link
Contributor Author

Just a friendly check in on this. I see this warning in so many logs, and I don't like relying on Suppressor etc.

@mattBrzezinski
Copy link
Member

Sorry Ian, I've really been too busy to spend any time on this package and realistically probably won't have the capacity any time in the near future. :(

@IanButterworth
Copy link
Contributor Author

No worries! I'll see if I can figure it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants