Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize does not work for bigint #74

Open
kessido opened this issue Feb 2, 2021 · 3 comments
Open

Memoize does not work for bigint #74

kessido opened this issue Feb 2, 2021 · 3 comments

Comments

@kessido
Copy link

kessido commented Feb 2, 2021

I wanted to let you know that @memoize for function that recive bigint does not act as expected.

image

@cstjean
Copy link
Collaborator

cstjean commented Feb 3, 2021

Yes, I suppose that is a consequence of the IdDict default. Does it work if you @memoize Dict() function f(x) ...?

@kessido
Copy link
Author

kessido commented Feb 4, 2021

Yes, Tho I would suggest using Dict by default then as it add some underling logic prone to bugs.

image

@cstjean
Copy link
Collaborator

cstjean commented Feb 5, 2021

Yeah... I didn't make that call. It would be a breaking change, but I think I agree with you there. IdDict is IMO premature optimization for this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants