Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import LLVM.Interop functionality #7

Closed
maleadt opened this issue Mar 21, 2023 · 1 comment
Closed

Import LLVM.Interop functionality #7

maleadt opened this issue Mar 21, 2023 · 1 comment

Comments

@maleadt
Copy link
Member

maleadt commented Mar 21, 2023

As part of LLVM.jl 5, I'm removing the atomics-related functionality that was added to the LLVM.Interop module in maleadt/LLVM.jl#308. The functionality has some issues (@dynamic_order generating code for all cases is invalid, e.g., AtomicRMW cannot be used with Unordered and causes an abort on LLVM 15), but in hindsight I also think that it doesn't really belong in LLVM.jl which provides lightweight wrappers around the LLVM APIs, and by extension some functionality to interface with Julia's LLVM support (i.e. llvmcall, LLVMPtr, etc).

This change wont break UnsafeAtomicsLLVM.jl because it's part of the breaking LLVM 5.0 release, but opening an issue so that it's clear that this code needs to be imported here before bumping the compat bounds: https://github.com/maleadt/LLVM.jl/blob/ba3d82d56a789bd0c48f372be38ae52407372f2f/src/interop/atomics.jl

@vchuravy
Copy link
Member

Partially done in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants