-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with AxisArrayConversion #4
Comments
Thanks for opening this. Regarding your first 2 points I have created #5 which implements the interface for Named Tuples. Is this what you envisioned. I would still like to discuss if the code should remain in this package or should be renamed and moved to a different place/package. To provide some background I have a package that provides some processing on top of large disk-based AxisArray-like arrays and initially started with my homegrown axis array type. Then I came to the point where I wanted to discard my own type and move to a different package and be independent of the actual axis array implementation, so I made this package to support different types of axis arrays and called it YAXArrayBase, because it provides the interface to work with the YAXArray.jl package. My main concern with keeping the code inside this package would be that it might be recognized as biased towards the usage within YAXArrays, Another concern is that there is also a second interface defined for datasets, which mimic file data structures like NetCDF CF conventions which don't really belong to this concept. So my suggestion would be to take the code inside src/axisarray and put it into a new package which might live in an organisation or think about if some of the functions defined here might become part of Arrayinterface.jl |
#5 is what I had in mind. There are minor details, like the default dim names, that I would personally do differently, but I can live with that. |
Yes, having a AxisArrayInterface.jl sounds reasonable. Regarding the default dim names, I am completely open, what would be your preferred solution? I think using x,y,z does not really work because there are higher-dimensional arrays as well and we would run out of letters (at least when starting at |
My personal preference is |
From discourse merge this package with AxisArrayConversion. As you say we should probably merge the two packages.
So how about
merge!(YAXArrayBase, AxisArrayConversion)
and deprecating my package.I think our packages have a bit different philosophy though. So here are some features/goals of AxisArrayConversion
and I would like to know whether you are open to supporting them here:
NamedTuple
The text was updated successfully, but these errors were encountered: