Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some failing doctests #579

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Update some failing doctests #579

merged 4 commits into from
Aug 10, 2023

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 10, 2023

The main change seems to be the @ notation.

I was motivated by decreasing annoying noise, cf #575 (comment)

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #579 (1ecb156) into master (43f2041) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files          12       12           
  Lines        2531     2531           
=======================================
  Hits         2188     2188           
  Misses        343      343           
Files Changed Coverage Δ
src/construct.jl 91.16% <ø> (ø)

@timholy
Copy link
Member Author

timholy commented Aug 10, 2023

1ecb156 is a little weird: on my machine it prints as d (disabled) but the right answer surely is c. I've left it c in the docs but added a filter so it isn't picky. Feel free to suggest an alternative.

@timholy
Copy link
Member Author

timholy commented Aug 10, 2023

Seems good now.

@timholy timholy merged commit 1d87867 into master Aug 10, 2023
9 of 16 checks passed
@timholy timholy deleted the teh/update_doctests branch August 10, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant