Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in type inferrability #121

Open
gdalle opened this issue Oct 27, 2023 · 5 comments
Open

Regression in type inferrability #121

gdalle opened this issue Oct 27, 2023 · 5 comments
Labels
question Inquiries and discussions

Comments

@gdalle
Copy link
Member

gdalle commented Oct 27, 2023

When I bumped AbstractDifferentiation compat to 0.6 on ImplicitDifferentiation, I got type inference errors in ChainRulesTestUtils that were not there before. Probably a regression due to the latest changes. Any idea what might have worsened inference @devmotion ?
https://github.com/gdalle/ImplicitDifferentiation.jl/actions/runs/6659445596/job/18098532825

@devmotion
Copy link
Member

Are you sure that these are caused by AbstractDifferentiation? Was the AbstractDifferentiation update the only change compared with e.g. runs on the master branch? I wonder because, e.g., the latest Zygote release (0.6.67) also contains a few more fundamental changes (getindex adjoints were removed in favour of ChainRules).

@gdalle
Copy link
Member Author

gdalle commented Oct 30, 2023

I'll see if the tests still fail with the previous Zygote, thanks for the tip

@gdalle gdalle added the question Inquiries and discussions label Oct 30, 2023
@gdalle
Copy link
Member Author

gdalle commented Nov 10, 2023

I just checked, reverting to Zygote v0.6.66 doesn't fix things, but reverting to AbstractDifferentiation v0.5.3 does.

@mohamed82008
Copy link
Member

Can you post an MWE?

@gdalle
Copy link
Member Author

gdalle commented Mar 13, 2024

Unfortunately it was buried inside the ImplicitDifferentiation.jl test suite, and I didn't have time to investigate, so I just deactivated the inference tests to be able to update to [email protected] in the compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Inquiries and discussions
Projects
None yet
Development

No branches or pull requests

3 participants