-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in type inferrability #121
Comments
Are you sure that these are caused by AbstractDifferentiation? Was the AbstractDifferentiation update the only change compared with e.g. runs on the master branch? I wonder because, e.g., the latest Zygote release (0.6.67) also contains a few more fundamental changes ( |
I'll see if the tests still fail with the previous Zygote, thanks for the tip |
I just checked, reverting to Zygote v0.6.66 doesn't fix things, but reverting to AbstractDifferentiation v0.5.3 does. |
Can you post an MWE? |
Unfortunately it was buried inside the ImplicitDifferentiation.jl test suite, and I didn't have time to investigate, so I just deactivated the inference tests to be able to update to [email protected] in the compat |
When I bumped AbstractDifferentiation compat to 0.6 on ImplicitDifferentiation, I got type inference errors in ChainRulesTestUtils that were not there before. Probably a regression due to the latest changes. Any idea what might have worsened inference @devmotion ?
https://github.com/gdalle/ImplicitDifferentiation.jl/actions/runs/6659445596/job/18098532825
The text was updated successfully, but these errors were encountered: