Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more types supported with bundle helper #205

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

oxinabox
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -1.33% ⚠️

Comparison is base (8dd45c0) 56.42% compared to head (b60acd4) 55.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   56.42%   55.09%   -1.33%     
==========================================
  Files          28       28              
  Lines        2896     2797      -99     
==========================================
- Hits         1634     1541      -93     
+ Misses       1262     1256       -6     
Files Changed Coverage Δ
src/AbstractDifferentiation.jl 92.85% <88.88%> (+5.35%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox oxinabox merged commit 20e7f32 into main Aug 21, 2023
7 of 8 checks passed
@oscardssmith oscardssmith deleted the ox/bundle_helper branch August 21, 2023 13:08
@oxinabox
Copy link
Member Author

sigh, this was slightly different to what I was doing when i tested it out,
and i introduced ambiguity errors.
I have a fix. Which I will put in soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant