Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Systems submodule to v3 #7

Open
Datseris opened this issue Feb 6, 2023 · 5 comments
Open

Update Systems submodule to v3 #7

Datseris opened this issue Feb 6, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Datseris
Copy link
Member

Datseris commented Feb 6, 2023

Easy TODO that means doing the following:

  • Make sure all functions that return dynamical systems do not pass Jacobian into the constructors
  • Replace all calls to @SMatrix to regular SMatrix calls, so that we can remove the StaticArrays dependency
  • Ensure all functions follow the naming convention stated in the Systems docstring.
@Datseris Datseris added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 6, 2023
@SergeyNovak777
Copy link
Contributor

Hello i wanted to help with it. I have one question about Jacobian. Should the Jacobian be removed only from the constructor, or should the Jacobian function also be removed?

@Datseris
Copy link
Member Author

keep the jacobian function with the syntax name_jacob (name of the system)

@Datseris Datseris transferred this issue from JuliaDynamics/DynamicalSystemsBase.jl Feb 27, 2023
@rusandris
Copy link
Contributor

Hi! I noticed this was broken so I created a PR. Check it out and let me know is something's still not right

@rusandris
Copy link
Contributor

Question: SVector and SMatrix are from StaticArrays, right? So the dependency cannot be removed yet, can it?

@Datseris
Copy link
Member Author

SVector, SMatrix come from StaticArraysCore.jl. So the StaticArrays dependency will be removed once we have stopped using the @SMatrix macro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants