Updated ReducedSystem and renamed to HRedSys (including tutorial)
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and PSDArch), SymplecticEncoder and SymplecticDecoder.
Made PSDArch a subtype of SymplecticCompression.
… of a whole GeometricEnsemble).
…so used in the reduced system.
…nsion must conform with the problem.
Added symplectic autoencoder architecture.
Added docstrings. Added docstrings. Added docstrings for AutoEncoderLoss.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 68.13% 69.54% +1.40%
==========================================
Files 119 119
Lines 3314 3352 +38
==========================================
+ Hits 2258 2331 +73
+ Misses 1056 1021 -35 ☔ View full report in Codecov by Sentry. |
michakraus
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents of pull request:
ReducedSystem(reduced_system.jl)ReducedSys->HRedSystem(renaming)compute_projection_error->projection_error(renaming)compute_reduction_error->reduction_error(renaming)HODEProblemfrom GI (i.e. there are now two vector fieldsvandfand a hamiltonianhfor the full system AND the reduced system).HRedSysis called with anHODEProblem, an encoder and a decoder (there is an additional keyword argument specifying the integrator).SymplecticCompression,SymplecticEncoderandSymplecticDecoder(autoencoder.jl,psd.jlandsymplectic_auotencoder.jl)SymplecticCompressionforSymplecticAutoencoderandPSDArch.SymplecticEncoderfor the encoders of the symplectic autoencoder and PSD.SymplecticDecoderfor the decoders of the symplectic autoencoder and PSD.