Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAE script multiple parameters #161

Merged
merged 14 commits into from
Jul 3, 2024
Merged

Conversation

benedict-96
Copy link
Collaborator

Modified the SAE script (scripts/symplectic_autoencoders/online_sympnet.jl) such that it works with multiple parameters and improved the DataLoader docs and docstrings.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 41.86047% with 25 lines in your changes missing coverage. Please review.

Project coverage is 68.42%. Comparing base (d631994) to head (1af0589).
Report is 5 commits behind head on main.

Files Patch % Lines
src/data_loader/data_loader.jl 41.93% 18 Missing ⚠️
src/reduced_system/reduced_system.jl 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   69.23%   68.42%   -0.81%     
==========================================
  Files         122      122              
  Lines        3614     3614              
==========================================
- Hits         2502     2473      -29     
- Misses       1112     1141      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96 benedict-96 marked this pull request as draft July 3, 2024 08:21
@benedict-96 benedict-96 marked this pull request as ready for review July 3, 2024 08:31
@benedict-96 benedict-96 requested a review from michakraus July 3, 2024 11:20
@michakraus michakraus merged commit e4bc624 into main Jul 3, 2024
11 of 13 checks passed
@michakraus michakraus deleted the sae_script_multiple_parameters branch July 3, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants