Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ifs that originated in a KernelAbstractions Problem #166

Closed
benedict-96 opened this issue Aug 8, 2024 · 1 comment · Fixed by #169
Closed

Remove ifs that originated in a KernelAbstractions Problem #166

benedict-96 opened this issue Aug 8, 2024 · 1 comment · Fixed by #169

Comments

@benedict-96
Copy link
Collaborator

This can be done once JuliaGPU/KernelAbstractions.jl#504 has been fixed.

@benedict-96 benedict-96 changed the title Remove ifs that originated in a KernelAbstractionsProblem Remove ifs that originated in a KernelAbstractions Problem Aug 19, 2024
@benedict-96
Copy link
Collaborator Author

benedict-96 commented Aug 27, 2024

This appears in

function Base.zeros(backend::KernelAbstractions.Backend, ::Type{StiefelLieAlgHorMatrix{T}}, N::Integer, n::Integer) where T
StiefelLieAlgHorMatrix(
zeros(backend, SkewSymMatrix{T}, n),
N == n ? KernelAbstractions.allocate(backend, T, N-n, n) :
KernelAbstractions.zeros(backend, T, N-n, n), N, n)
end
for example. The if should not be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant