Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce the 'blocking' kwargs to at-sync. #2060

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 25, 2023

This can be used to force a blocking, but low-latency synchronization, e.g., when benchmarking code that uses a single task.

Marked as draft, because I don't want to merge this before I'm convinced that #2059 recovered the performance we lost.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +29.75% 🎉

Comparison is base (ac1bc29) 29.55% compared to head (8e11d6f) 59.30%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2060       +/-   ##
===========================================
+ Coverage   29.55%   59.30%   +29.75%     
===========================================
  Files         157      152        -5     
  Lines       13834    13311      -523     
===========================================
+ Hits         4088     7894     +3806     
+ Misses       9746     5417     -4329     
Files Changed Coverage Δ
lib/cudadrv/synchronization.jl 96.06% <100.00%> (+33.85%) ⬆️
src/utilities.jl 75.70% <100.00%> (+6.83%) ⬆️

... and 110 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt
Copy link
Member Author

maleadt commented Aug 30, 2023

Actually, I shouldn't be worried merging this: It only changes how we synchronize the outer CUDA.@sync, not what's done within. So when benchmarking, e.g., a memory copy, or an operation that synchronizes, we'd still be benchmarking the nonblocking sync within. So let's just add a couple of synchronization benchmarks.

@maleadt maleadt marked this pull request as ready for review August 30, 2023 05:35
This can be used to force a blocking, but low-latency synchronization,
e.g., when benchmarking code that uses a single task.
@maleadt maleadt merged commit d95ba8e into master Aug 30, 2023
@maleadt maleadt deleted the tb/at_sync_blocking branch August 30, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant