Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiplication of adjoint matrices by diagonal matrices #2482

Closed

Conversation

RedRussianBear
Copy link
Contributor

Fixes an issue where if an adjoint matrix is passed to mul! with a diagonal, it falls back to the iterative LinearAlgebra method

@maleadt
Copy link
Member

maleadt commented Sep 5, 2024

CI failures look related?

@maleadt maleadt added enhancement New feature or request cuda libraries Stuff about CUDA library wrappers. needs changes Changes are needed. labels Sep 5, 2024
@amontoison
Copy link
Member

You could add a metaprogramming loop for Transpose and Adjoint and still rely on dgmm!

@maleadt maleadt marked this pull request as draft September 18, 2024 08:36
@maleadt
Copy link
Member

maleadt commented Oct 7, 2024

Closing in favor of #2518.

@maleadt maleadt closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda libraries Stuff about CUDA library wrappers. enhancement New feature or request needs changes Changes are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants