Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sum zero-arrays #363

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Sum zero-arrays #363

wants to merge 8 commits into from

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Jun 22, 2021 •
edited
Loading

Closes #362

Does not handle keywords, note that dims is an error on normal Arrays, but init is respected so perhaps should be here too:

julia> sum(fill(3), init=99)
102

julia> sum(fill(3), dims=1)
ERROR: BoundsError: attempt to access Tuple{} at index [1]

CI failure for GPU seems to be printing code?

@maleadt
Copy link
Member

maleadt commented Jul 22, 2021

Good to go?

@mcabbott
Copy link
Contributor Author

Sadly not -- status when last I looked was that my "better way" seemed not to be called at all, and I wasn't sure why.

@maleadt maleadt mentioned this pull request Oct 5, 2021
Closed
@maleadt maleadt added the stale label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sum of zero-array fails
2 participants
@mcabbott @maleadt