StackOverflow for `get_device` on `ROCArray`

[leios]

julia> a = ROCArray(rand(10,10));

julia> KernelAbstractions.get_device(a)
ERROR: StackOverflowError:
Stacktrace:
 [1] get_device(A::ROCMatrix{Float64}) (repeats 79984 times)
   @ KernelAbstractions ~/.julia/packages/KernelAbstractions/DqITC/src/KernelAbstractions.jl:355

Calling AMDGPU.device(a) works:

julia> AMDGPU.device(a)
GPU-XX [AMD Radeon RX 6700 XT (gfx1030)]

So maybe there's a way to get rid of one layer of abstraction here?

As a note:

julia> b = Array(rand(10,10));

julia> KernelAbstractions.get_device(b)
CPU()

So shouldn't we be returning ROCdevice() instead of GPU-XX [AMD Radeon RX 6700 XT (gfx1030)]? Or was there something about the recent change with how ROCDevice() that changes things?

[jpsamaroo]

KernelAbstractions.get_device(::ROCArray) should return the same as AMDGPU.device(a); we removed the old ROCKernels.ROCDevice in favor of just using AMDGPU's ROCDevice, which happens to point to a concrete GPU device.

[vchuravy]

We should also finish #320