Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples don't use correct version of ApproximateGPs #105

Open
devmotion opened this issue Jan 29, 2022 · 3 comments · May be fixed by #106
Open

Examples don't use correct version of ApproximateGPs #105

devmotion opened this issue Jan 29, 2022 · 3 comments · May be fixed by #106

Comments

@devmotion
Copy link
Member

I didn't see any discussion about this so I assume that #99 might have changed it unintentionally and introduced a bug: In contrast to previous behaviour and when e.g. building the documentation, with this PR now examples use the latest compatible released version of ApproximateGPs instead of e.g. the master branch or a PR. So it can happen that examples run fine in a PR but fail as soon as the next release is tagged.
@devmotion devmotion linked a pull request Jan 30, 2022 that will close this issue
Open
@st--
Copy link
Member

st-- commented Jan 31, 2022

Woops, yes, definitely an unintentional bug. Thanks for spotting it!

@rossviljoen rossviljoen mentioned this issue Feb 27, 2022
Closed
@st--
Copy link
Member

st-- commented Mar 17, 2022

fixed by #119

@st-- st-- closed this as completed Mar 17, 2022
@devmotion
Copy link
Member Author

That's only a workaround, not a proper fix. The manifest files and package information obtained with the linked PR (which BTW introduced formatting issues and should not have been merged it seems) are not helpful for reproducing the examples. Instead of the development version they should use the corresponding release or commit if run on the master branch.

@devmotion devmotion reopened this Mar 17, 2022
@devmotion devmotion changed the title Examples don't use development version of ApproximateGPs Examples don't use correct version of ApproximateGPs Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use same ApproximateGPs version for docs and examples JuliaGaussianProcesses/ApproximateGPs.jl
2 participants
@devmotion @st--