Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method value(::Nothing) #68

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Add method value(::Nothing) #68

merged 3 commits into from
Feb 6, 2024

Conversation

simsurace
Copy link
Member

I did not notice this, but of course this is required to make the full use case work.
I threw in a nothing in the integration test.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@ccfdc13). Click here to learn what that means.

❗ Current head d65911b differs from pull request most recent head a4a0e79. Consider uploading reports for the commit a4a0e79 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage          ?   97.37%           
=========================================
  Files             ?        8           
  Lines             ?      229           
  Branches          ?        0           
=========================================
  Hits              ?      223           
  Misses            ?        6           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI passes, and the patch version has been bumped, I'm happy for this to be merged.

@simsurace simsurace merged commit d41e693 into master Feb 6, 2024
5 checks passed
@simsurace simsurace deleted the value-nothing branch February 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants