-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for curved geometries #215
base: master
Are you sure you want to change the base?
Conversation
One thing I did not yet figure out how to get the geometries from a
|
Failures on nightlies {ubuntu, macOS, windows}-latest are due to Makie not compiling under Julia Version 1.12.0-DEV.1908. Not related to this PR. |
Thanks for working on this! ❤️
A CompoundCurve is a collection, so I'd say ngeom counts for the number of segments. This has one, and getgeom will get you the CircularString. While it maybe confusing from a Curve perspective (expecting ngeom to be the number of points), I'd say it fits the indentation (ngeom is just the number of things between brackets on level down). |
@evetion , I am still confused since
Also,
That said, I am indifferent if this PR gets accepted or not. No hurries. |
Add basic support
CircularString
,CompoundCurve
,CurvePolygon
,MultiCurve
,MultiSurface
. Reading WKT tests added.Lots of additional methods to be added for constructing geometries. Those should fall under
open_issue_if_conversion_makes_sense
for now.