Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting stuff needs to move elesewhere #19

Open
3 tasks
j-fu opened this issue Nov 24, 2023 · 0 comments
Open
3 tasks

Plotting stuff needs to move elesewhere #19

j-fu opened this issue Nov 24, 2023 · 0 comments

Comments

@j-fu
Copy link
Member

j-fu commented Nov 24, 2023

Plotting (with PyPlot and now Makie) was added here for convenience. Dependencies are weak, as the Plotter module is passed to the plotting methods, so not much overhead when this is ignored. With the extension mechanism, finally there is a way to check for version consistency. As wee see in bdfb889, this now requires to track updates of plotting packages which is completely out of scope of this package.

So this needs to be cleaned up.

The plan:

  • Copy the plotting stuff elsewhere. I consider GridVisualize.jl (which then would get a GridVisualizeTriangulateExt extension) the right place as IMHO a TriangulatePlotting package would be over the top.
  • Deprecate plotting methods in Triangulate.jl (perhaps in v2.3)
  • After a grace period (a couple of weeks), remove the plotting methods from Triangulate.jl. As this would be breaking, this will be v3.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant