Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt for duplicate layer's implementations in GNN.jl and GNNLux.jl #561

Open
CarloLucibello opened this issue Dec 17, 2024 · 0 comments
Open

opt for duplicate layer's implementations in GNN.jl and GNNLux.jl #561

CarloLucibello opened this issue Dec 17, 2024 · 0 comments
Labels
flux lux

Comments

@CarloLucibello
Copy link
Member

Right now, Flux and Lux layers are just tiny wrappers are the forward pass implementation that lives in GNNlib.jl. While it is nice to share the code, I think that the price we pay in code readability is too high.

Maybe we should just have duplicated implementations in GraphNeuralNetworks.jl and GNNLux.jl.
@CarloLucibello CarloLucibello changed the title duplicate layer's implementations in GNN.jl and GNNLux.jl opt for duplicate layer's implementations in GNN.jl and GNNLux.jl Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flux lux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CarloLucibello