Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable idiomatic record.pt syntax #113

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Enable idiomatic record.pt syntax #113

merged 2 commits into from
Oct 24, 2024

Conversation

ianna
Copy link
Member

@ianna ianna commented Oct 23, 2024

No description provided.

@ianna ianna linked an issue Oct 23, 2024 that may be closed by this pull request
Enable idiomatic record.pt syntax #112
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.00%. Comparing base (6ba1c4a) to head (b5ec985).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/all_implementations.jl 36.84% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   76.09%   76.00%   -0.09%     
==========================================
  Files           5        5              
  Lines        1740     1742       +2     
==========================================
  Hits         1324     1324              
- Misses        416      418       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf
Copy link
Member

Moelf commented Oct 23, 2024

do you want to do it for other Record* in this same PR?

@ianna
Copy link
Member Author

ianna commented Oct 23, 2024

do you want to do it for other Record* in this same PR?

yes, there is more to it :-)

@ianna ianna marked this pull request as draft October 23, 2024 14:41
@ianna ianna marked this pull request as ready for review October 23, 2024 15:09
@ianna ianna requested a review from Moelf October 23, 2024 15:40
ianna
ianna commented Oct 23, 2024
View reviewed changes
Copy link
Member Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Moelf - please, check if I missed anything. Thanks!

@ianna ianna merged commit 66a3807 into main Oct 24, 2024
6 of 8 checks passed
@ianna ianna deleted the ianna/112-enable-idiomatic-recordpt-syntax branch October 24, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moelf Moelf Moelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable idiomatic record.pt syntax
2 participants
@ianna @Moelf