-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indents for JSON files for readbility #167
base: master
Are you sure you want to change the base?
Conversation
Should this be a choice / keyword argument instead? Maybe it could propagate down from |
Yes, minimizing the JSON files saves disk space so adding indents should be optional. |
Agree. I just revised it and made it a keyword arguments |
Co-authored-by: Anshul Singhvi <[email protected]>
Co-authored-by: Anshul Singhvi <[email protected]>
Co-authored-by: Anshul Singhvi <[email protected]>
Co-authored-by: Anshul Singhvi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the PR! @meggart should probably review as well.
Test failures are from the pangeo AWS bucket that went down.
The library writes json files minimized which is difficult to read.
e.g.
Added indents for readability.