-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛣️🗺️ for LieGroups.jl #5
Comments
This is awesome! Thanks Ronny! |
Nice list! I think we should also move group actions here. |
Well-spotted, sure they should move as well. I will try to find time to write down a few design remarks and introduce the first main types maybe until or over the weekend. and then we could try to slowly move some parts |
There might be a few small hiccups from now, since we are taking over the old LieGroups.jl and rebase this. |
@ExpandingMan, @alxbnct, @oameye thanks for so early staring out repository again. Don't be confused, this is an old repository we took over to get the name LieGroups.jl, so while this might look like the one you stared, it is not. Feel free to star this one to stay up to date. Of course any comments, remarks, feature requests are also always welcome while we continue the rework. |
@dev10110 I just noticed we might have “lost” you as well on this issue when we moved everything to the (old, original) LieGroups.jl repository we took over to gain the name. Feel free to further comment if you miss a Lie Group or other features on the list here :) |
With yesterdays PR merge we now have
I will tackle power, product and semidirect products in a PR, since those can be done a bit nicer than we endet up with in the “grown-over-time” variant we had before. If anyone has time, the simple groups like rotations (SO(n), SU(n))... could all also be transferred already with their group operations. |
🛣️🗺️ for LieGroups.jl
Project.toml
,LICENSE
, theauthors=
field in thedocs/make.jl
, and the.zenodo.json
notation.md
to fix notationGroupManifold
should becomeLieGroup
Identity
inv(G,p)
(for types as above alsoinv(p)
compose
(for types as above also overload_compose
– that is handle interaction with the identity element incompose
and document this to be implemented for groups actually.identity_element
(an din-place)ActionDirection
, left and rightHasRightInvariantMetric
(and left- and bi-) maybe also introduce the traitIsLieGroup
exp_inv
should become the defaultexp(G, p, X)
here. (similarly log)exp_lie
should either become theexp(G, X)
above, similarly (log)get_vector_lie
andget_coordinates_lie
can maybe be refactored to work on groups without a base point? Or on a newLieAlgebra
subtype (similar to the tangent space we have)inv_diff
inverse_translate_diff
we should probably decide whether we do shorteninv
or we do not, we should probably not because there is inverse and invariant now alreadysince the Lie group is no longer a decorator this is obsoleteis_group_manifold
should probably becomeis_Lie_group
is_idenity
lie_bracket
switch_direction
->switch
obsolete after unifying operationsswitch_side
translate
translate_diff
hat
vee
AdditionOperation
asAdditionGroupOpertaion
MultiplcationOperation
CircleGroup
RealCircleGroup
GeneralLinear
HeisenbergGroup
LieGroup(product, tuple-of-operations)
instead?SemidirectProductGroup
SpecialEuclidean
SpecialLinear
TranslationGroup
.gitignore
about.md
to mention contributors (and what they contributed) as well as interesting related projects, for exampleFurther ideas both in form on further issues (I will link here) as well as comments are are welcome.
Let's first collect the ideas before we get started.
The text was updated successfully, but these errors were encountered: