Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear option normal in round function #39

Open
hurak opened this issue Sep 11, 2019 · 0 comments
Open

Unclear option normal in round function #39

hurak opened this issue Sep 11, 2019 · 0 comments

Comments

@hurak
Copy link
Contributor

hurak commented Sep 11, 2019

I find the role of normal option in round function quite unclear and perhaps even confusing. Does it read "normalize after rounding"? The code on line 5 and 9 speaks against it:

(normal) ? x : normalize(x, rounded=true)

If it is to be read as "do not normalize", the name of this variable is confusing. The more so that there is no docstring there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant