-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbounded isapprox #132
Comments
I guess the real question is what is "relative" wrt what? I assume you are happy that But I agree your example returning |
Yes, I think the behavior for finite intervals is correct and totally expected.
Agree, and don't have a solution ready. That's why an issue and not a PR. |
It doesn't actually help with this problem but looking at the code the choice of relative tolerance looks wrong: I think |
Then we'd get weird situations when |
I don't think that's a "weird situation" at all... and in fact those two intervals do not look approximately equal. |
What about |
Currently,
isapprox
relative tolerance is based on the maximum of interval endpoints. This makes a lot of sense for finite intervals, but is kinda weird for infinities:Do you think this can be fixed/improved in a consistent manner?
The text was updated successfully, but these errors were encountered: