-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AtomsBase not properly implemented #128
Comments
I can start working on some of these changes, were there any other functions you noticed missing or broken? |
I'd say that by integrating with AtomsBaseTesting you should find most of the problems automatically. The package tries to test the full AtomsBase interface. Take a look at the other packages which use AtomsBaseTesting as part of their tests to see how it is done. If this does not help you, ping me and I'm happy to point you in the right direction. |
Thanks for pointing this out Michael - we'll add AtomsBaseTesting and fix any issues. |
Should be fixed by #131. |
Just a remark that I noted that the latest AtomsBase interface (0.3) is not properly supported by Molly. E.g.
hasatomkey(sys, :testkey)
on a Molly system gives an infinite stacktrace.We should take a look at this and integrate with
AtomsBaseTesting
in the CI of Molly.The text was updated successfully, but these errors were encountered: