do not allocate in x_converged
#54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose preallocating y is an alternative ? |
|
it is an alternative. Ideally, there should be a way to calculate |
|
tests failed it seems |
|
ah that was the anderson test |
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
=========================================
Coverage ? 76.47%
=========================================
Files ? 54
Lines ? 2776
Branches ? 0
=========================================
Hits ? 2123
Misses ? 653
Partials ? 0 |
|
Looks like CI passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it changes
y = x .- zfor an iterator. ideally, a custom struct could be provided for this, i imagine some problems could arise if using CUArrays?