Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on 1.11 #147

Closed
KristofferC opened this issue Apr 22, 2024 · 3 comments
Closed

Tests fail on 1.11 #147

KristofferC opened this issue Apr 22, 2024 · 3 comments

Comments

@KristofferC
Copy link

(Same as jw3126/Setfield.jl#179)

IR: Test Failed at /home/pkgeval/.julia/packages/Accessors/81CPQ/test/perf.jl:92
  Expression: uniquecounts(heads_lens) == uniquecounts(heads_hand)
   Evaluated: Dict(:call => 9, :new => 1) == Dict(:call => 3, :new => 1)

Stacktrace:
 [1] macro expansion
   @ /opt/julia/share/julia/stdlib/v1.11/Test/src/Test.jl:679 [inlined]
 [2] test_ir_lens_vs_hand(info_lens::Core.CodeInfo, info_hand::Core.CodeInfo)
   @ Main.Perf ~/.julia/packages/Accessors/81CPQ/test/perf.jl:92
 [3] macro expansion
   @ ~/.julia/packages/Accessors/81CPQ/test/perf.jl:139 [inlined]
 [4] macro expansion
   @ /opt/julia/share/julia/stdlib/v1.11/Test/src/Test.jl:1700 [inlined]
 [5] macro expansion
   @ ~/.julia/packages/Accessors/81CPQ/test/perf.jl:137 [inlined]
 [6] macro expansion
   @ /opt/julia/share/julia/stdlib/v1.11/Test/src/Test.jl:1789 [inlined]
 [7] top-level scope
   @ ~/.julia/packages/Accessors/81CPQ/test/perf.jl:121
@aplavin
Copy link
Member

aplavin commented Apr 22, 2024

Which 1.11 version specifically? I ran tests on github actions for several versions, and both 1.11s fail with a different error:

@accessor: Test Failed at /home/runner/work/Accessors.jl/Accessors.jl/test/test_core.jl:604
  Expression: strip(string(#= /home/runner/work/Accessors.jl/Accessors.jl/test/test_core.jl:604 =# @doc(my_x))) == "Documentation for my_x"
   Evaluated: "nothing" == "Documentation for my_x"

For some reason, @doc ... seems to return nothing instead of the docstring – not sure if a known regression or not. Anyway, different error from what you show.

See full test run at https://github.com/aplavin/Accessors.jl/actions/runs/8782924455/job/24098041340.

@KristofferC
Copy link
Author

I ran tests on github actions for several versions, and both 1.11s fail with a different error:

That is known: JuliaLang/julia#52986.

The error for this comes from PkgEval on the backport branch: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/bdc7fb7_vs_bd47eca/Accessors.primary.log

@aplavin
Copy link
Member

aplavin commented Oct 16, 2024

Tests pass now, after #175. The issue from your first message here didn't manifest itself in the end, only the @doc regression :)

@aplavin aplavin closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants