[AutoBuild] Fix filter_main_tarball
#1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
changed the title
filter_main_tarballfilter_main_tarball
|
Thanks for fixing this! |
I'm afraid that's not possible, the version of BinaryBuilder is taken from the checked in registry in each revision (which I just updated in JuliaPackaging/Yggdrasil#10617), you'll have to trigger again a new build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue encountered in JuliaPackaging/Yggdrasil#10611 (comment).
There were actually two issues that are fixed by this PR:
filter_main_tarballgets a path and not a filename as the first arg.anyI don't think there is a way to test it apart from somehow getting this version into the yggdrasil toolchain and re-running CI on JuliaPackaging/Yggdrasil@3751eec again. (Which would be great to have anyway to get the GAP_lib_jll release from there into the registry.)
cc @fingolfin @giordano