Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Finds incorrect library name due to startswith() check #177

Open
staticfloat opened this issue Sep 3, 2019 · 2 comments
Open

Finds incorrect library name due to startswith() check #177

staticfloat opened this issue Sep 3, 2019 · 2 comments

Comments

@staticfloat
Copy link
Member

https://github.com/JuliaPackaging/BinaryProvider.jl/blob/master/src/Products.jl#L158

Finds libcairo-script-interpreter when it should find just libcairo

@giordano
Copy link
Member

Duplicate of #133

@fingolfin
Copy link
Member

A simple fix (albeit not perfect) would be check if the name starts with basename(f) followed by . or - (the latter for Windows). Of course that would still not be perfect; but on my computer, it would handle all cases except for libprotobuf.dylib vs. libprotobuf-lite.dylib. If one restricts the check to only allow - on Windows, that would thus make this even more general.

Better would of course be to a function which computes resp. checks the "libname" by following the rules the linker actually uses (but I expect that there are minor differences there between different Unix variants...?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants