Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wall-time profiles to ProfileEndpoints.jl #50

Merged
merged 7 commits into from
Dec 24, 2024
Merged

Add wall-time profiles to ProfileEndpoints.jl #50

merged 7 commits into from
Dec 24, 2024

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Dec 24, 2024

  • Through the HTTP endpoints:
    • /profile_wall
    • /profile_wall_start
    • /profile_wall_stop
  • Through the debug super-endpoint:
    • /debug_engine profile_type="wall_profile"
    • /debug_engine profile_type="wall_profile_start"
    • /debug_engine profile_type="wall_profile_stop"

@NHDaly
Add wall-time profiles to ProfileEndpoints.jl
208e5a0 
- Through the HTTP endpoints:
    - /profile_wall
    - /profile_wall_start
    - /profile_wall_stop
- Through the debug super-endpoint:
    - /debug_engine profile_type="wall_profile"
    - /debug_engine profile_type="wall_profile_start"
    - /debug_engine profile_type="wall_profile_stop"
@NHDaly NHDaly requested a review from d-netto December 24, 2024 17:50
@NHDaly
Copy link
Member Author

NHDaly commented Dec 24, 2024

Tagging @vustef for review.

@NHDaly NHDaly mentioned this pull request Dec 24, 2024
Merged
@NHDaly NHDaly force-pushed the nhd-add-wall-profiling branch from 1d55504 to 9136f9a Compare December 24, 2024 18:21
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.57143% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.33%. Comparing base (ffd6913) to head (9136f9a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ProfileEndpoints.jl 78.57% 12 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #50       +/-   ##
===========================================
- Coverage   90.00%   76.33%   -13.67%     
===========================================
  Files           1        1               
  Lines         190      262       +72     
===========================================
+ Hits          171      200       +29     
- Misses         19       62       +43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vustef
vustef approved these changes Dec 24, 2024
View reviewed changes
Copy link

@vustef vustef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nathan! Looking good to me, as far as I can tell.

@NHDaly NHDaly merged commit 6590764 into main Dec 24, 2024
7 of 9 checks passed
@NHDaly NHDaly deleted the nhd-add-wall-profiling branch December 24, 2024 21:24
@NHDaly NHDaly changed the title Add wall-time profiles to ProfileEndpoints.jl [RAI-32583] Add wall-time profiles to ProfileEndpoints.jl Jan 3, 2025
@NHDaly NHDaly changed the title [RAI-32583] Add wall-time profiles to ProfileEndpoints.jl Add wall-time profiles to ProfileEndpoints.jl Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vustef vustef vustef approved these changes

@d-netto d-netto Awaiting requested review from d-netto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NHDaly @codecov-commenter @vustef