add aqua tests #332
Open
add aqua tests #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move jump to extension * support for regular dependency in julia 1.6 * reorganize JuMP ext * move RecipesBase and GeometryBasics to ext * uncomment verbose statement * add error message for Mesh * add news file describing breaking change * update docs * update examples * simplify doc * fix verbose print of model * remove exported JuMP function * import functions missing in GeometryBasicsExt * add missing compat entry
* move jump to extension * support for regular dependency in julia 1.6 * reorganize JuMP ext * move RecipesBase and GeometryBasics to ext * uncomment verbose statement * add error message for Mesh * add news file describing breaking change * update docs * update examples * simplify doc * fix verbose print of model * remove exported JuMP function * import functions missing in GeometryBasicsExt * add missing compat entry
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
==========================================
- Coverage 88.92% 88.81% -0.11%
==========================================
Files 37 37
Lines 3170 3175 +5
==========================================
+ Hits 2819 2820 +1
- Misses 351 355 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #328, I am opening a pr to address issues raised by Aqua.jl that could go into a breaking release of Polyhedra.jl. All of the changes are made are open to discussion, and I summarize them here:
removevredundancy,rmap,rrepsandsumpoints. A few ambiguities on*remain and I chose to ignore themhreps,points,hyperplanes,lines,rays, andhalfspacescould only enforce a parametrized coefficient type if they all accept at least one representation. Instead of adding an extra argument to all of the functions I usedpromoteto deduce the coefficient type. TheMeshtype had an uninitialized parameter that I initialized to an empty array by default.done*,start*andnext*were never defined, so I removed themFullDiminto aFullDimtype andtyped_fulldimfunction. An alternative is to turnFullDiminto a struct, likeStaticArrays.Size, but I found that more difficult to implement since it requires more than search+replace. Most likely this will break implementations of the Polyhedra.jl interface, e.g. CDDLib.jl.