Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine info-hook/update-hook into callback #71

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Combine info-hook/update-hook into callback #71

merged 1 commit into from
Jul 13, 2024

Conversation

goerz
Copy link
Member

@goerz goerz commented Jul 13, 2024

See JuliaQuantumControl/QuantumControlBase.jl#84

This also enables the new store_iter_info argument.

See JuliaQuantumControl/QuantumControlBase.jl#84

This also enables the new `store_iter_info` argument.
@goerz goerz added the breaking PRs that break compatibility label Jul 13, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 81.42857% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.1%. Comparing base (317f79a) to head (4b89da1).
Report is 11 commits behind head on master.

Files Patch % Lines
src/optimize.jl 78.0% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #71     +/-   ##
========================================
+ Coverage    87.0%   87.1%   +0.1%     
========================================
  Files           6       7      +1     
  Lines         521     571     +50     
========================================
+ Hits          453     497     +44     
- Misses         68      74      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goerz goerz merged commit 4b89da1 into master Jul 13, 2024
5 checks passed
@goerz goerz deleted the callback branch July 13, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking PRs that break compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant