Avoid unnecessary evaluation of chi #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an explicit `chi` is given, do not evaluate one with AD. Also, do not reconstruct a chi! routine in every Krotov iteration. Moving `make_chi` out of the iteration loop potentially avoids compilation overhead in each iteration.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
========================================
- Coverage 86.6% 86.3% -0.2%
========================================
Files 4 4
Lines 245 248 +3
========================================
+ Hits 212 214 +2
- Misses 33 34 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an explicit
chiis given, do not evaluate one with AD. Also, do not reconstruct a chi! routine in every Krotov iteration. Movingmake_chiout of the iteration loop potentially avoids compilation overhead in each iteration.