Make chi functions not-in-place
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `chi!` functions previously used by GRAPE and Krotov are now simply `chi` do not act in-place. This is more general and easier to implement for the user, as it allows to use immutable structs for states Note that in extreme performance-critical situations, one could still construct the χ-states in-place via a closure or functor. Both chi and J_T can now have an optional keyword argument `tau` (instead of the previous improperly implemented and unicode `τ`). Whether or not `tau` should be passed to these functions is automatically detected.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
========================================
- Coverage 82.3% 81.7% -0.5%
========================================
Files 4 4
Lines 287 300 +13
========================================
+ Hits 236 245 +9
- Misses 51 55 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chi!functions previously used by GRAPE and Krotov are now simplychido not act in-place. This is more general and easier to implement for the user, as it allows to use immutable structs for statesNote that in extreme performance-critical situations, one could still construct the χ-states in-place via a closure or functor.
Both chi and J_T can now have an optional keyword argument
tau(instead of the previous improperly implemented and unicodeτ). Whether or nottaushould be passed to these functions is automatically detected.