Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: CRNHexagon v0.1.0 #115546

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 4d9daa3a-052f-4e6c-a389-3aa07aaa8b0a
Repo: https://github.com/matthiashimmelmann/CRNHexagon.jl.git
Tree: c940ac263b05ca01929310e9f1b8c4230996dc6d

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Sep 20, 2024

Can you comment on why you would like to register the supplementary information from a paper as a package in General? Supplementary information typically doesn't meet the bar of being useful beyond the immediate context of the underlying paper, which does not make it a good candidate for General according to the guidelines in the README. It's certainly possible that some supplementary material could take the form of a package that other packages could use as a dependency, but the usage information in your README doesn't really hint at that. Note that packages do not need to be registered in order to be installed. Anyone can pull it from GitHub to verify the paper. The only thing that would make registration an absolute necessity is if other packages in General need it as a dependency, and then it might be better to structure and describe it independently from the paper.

I also don't see the connection between the package name and the paper, so it doesn't seem like the name is really descriptive of the package, which would be a requirement for registration.

@matthiashimmelmann
Copy link

Can you comment on why you would like to register the supplementary information from a paper as a package in General? Supplementary information typically doesn't meet the bar of being useful beyond the immediate context of the underlying paper, which does not make it a good candidate for General according to the guidelines in the README. It's certainly possible that some supplementary material could take the form of a package that other packages could use as a dependency, but the usage information in your README doesn't really hint at that. Note that packages do not need to be registered in order to be installed. Anyone can pull it from GitHub to verify the paper. The only thing that would make registration an absolute necessity is if other packages in General need it as a dependency, and then it might be better to structure and describe it independently from the paper.

I also don't see the connection between the package name and the paper, so it doesn't seem like the name is really descriptive of the package, which would be a requirement for registration.

Taking your reply into consideration, I do not think that adding the package to the General Julia repository is a useful thing to do. It is not intended to use the package as a dependency for other packages, as it is highly specialized for the solved problem. I retract the merging request and instead offer installation via Github in the README. Thanks for your help!

@goerz goerz closed this Sep 20, 2024
@giordano giordano deleted the registrator-crnhexagon-4d9daa3a-v0.1.0-cbe1c2177e branch November 9, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants