Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: NATS v0.1.0 #115613

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Sep 20, 2024

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
  • Name is not at least 5 characters long

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Sep 21, 2024

The name seems ok to me

UUID: 55e73f9c-eeeb-467f-b4cc-a633fde63d2a
Repo: https://github.com/jakubwro/NATS.jl.git
Tree: d9d9a189fb9155a460e6b5e8966bf6a66737abf8

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-nats-55e73f9c-v0.1.0-e2f55d0f26 branch from d89bb6a to 7b04a19 Compare September 21, 2024 13:23
JuliaRegistrator referenced this pull request in jakubwro/NATS.jl Sep 21, 2024
@jakubwro
Copy link

The name seems ok to me

Yes, this name matches other clients names like nats.py, nats.go, nats.js. I made it upper case as Julia packages usually use this convention for acronyms. Compat section is added now. Could you have a look @goerz if I did it right?
https://github.com/jakubwro/NATS.jl/blob/31685a3b3296e2c3285a1c5e0b09b7a6572c8c2e/Project.toml#L22

@goerz
Copy link
Member

goerz commented Sep 21, 2024

Seems like it. After the three-day waiting period ends, you can go on Slack to ask for a manual merge.

@giordano giordano merged commit df32467 into master Sep 24, 2024
14 of 16 checks passed
@giordano giordano deleted the registrator-nats-55e73f9c-v0.1.0-e2f55d0f26 branch September 24, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants