Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: DoME v1.0.0 #117468

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: b4f4f0b4-37e5-4265-8ded-9d4e2df27f01
Repo: https://github.com/danielriveroc/DoME.jl.git
Tree: 6204b08f1226bc1dc5c2ab270c4f9c517d08e622

Registrator tree SHA: 191228b6dd8b9d0e2965ae3e705fe54c51dcfee8
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Name is not at least 5 characters long
  • Package name similar to 9 existing packages.
    1. Similar to RoME. Damerau-Levenshtein distance 1 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1. Normalized visual distance 1.53 is at or below cutoff of 2.50.
    2. Similar to ACME. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    3. Similar to FAME. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    4. Similar to DSGE. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    5. Similar to DACE. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    6. Similar to Docx. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    7. Similar to Dojo. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    8. Similar to Dolo. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    9. Similar to ADCME. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@danielriveroc
Copy link

Could this package be manually merged? Automatic merge fails because the name is too short, and very similar to others. However, this is tha name given to the algorithm in the original publication, as can be ssen at: https://www.sciencedirect.com/science/article/pii/S0957417422001889
Therefore,it's best to keep the name of the package as the name of the algorithm.

@goerz
Copy link
Member

goerz commented Oct 17, 2024

Thank you for submitting your package! I might come around to just DoME, but it might be better to have it as part of a name, with a prefix or suffix that gives more context. Even something like MLDoME to put it in the context of machine learning.

But beyond the name, the package is also not ready for registration yet, since it is missing a README and other documentation. At the very least, that would be a description of the package's purpose and a small usage example in the README. In this case, it would have to include a link to the paper.

For an initial 1.0 release, the bar would be even higher. For a package with a stable version number, some of the requirements would be:

  • Must define the stable API. That generally means complete documentation. Sometimes that can be done in the README, but otherwise, Documenter would be recommended.
  • Must have tests with reasonable coverage (on the order of 80%). Otherwise, there's no way to know if the package actually implements its API correctly
  • Should somewhat reasonably fill the described scope of the package. No major gaps in functionality. If it's implementing a specific method from a paper, that would be the scope.

@danielriveroc
Copy link

Thank you for your comments. I have filled the README with a link to the paper, and a complete description of the API. Since, by now, it is only a single function that performs the whole work, I believe it is enough for now to leave the documentation in the README. However, I will use Documenter when the library grows and more functionalily is added.
The library has been extensively tested with over 100 datasets. Also, the tests in the tests folder should cover almost 100% of the source code, except those parts that were left for debugging/developing.
I hope that, with this, this package now meets all the requeriments.

@goerz
Copy link
Member

goerz commented Oct 17, 2024

Seems okay, in terms of documentation.

If you want to stick to the name, you would have to find a full registry maintainer on Slack and convince them to merge it manually. I don't have merge permissions.

I would still recommend finding a suitable package name that meets the minimum length requirement. With a name that is longer than 5 characters, this package would be set to auto-merge.

@glwagner
Copy link

glwagner commented Oct 18, 2024

Another option that's consistent with the paper is DevelopmentOfMathematicalExpressions.jl.

It's common for package names to spell out acronyms, eg AlgebraicMultigrid.jl is usually shortened to "AMG" when writing papers. A more verbose package name will help you advertise it to new users who otherwise might skip over the more terse and obscure "DOME", so there's good reason to consider it.

@goerz
Copy link
Member

goerz commented Oct 18, 2024

[noblock] Even though I'm potentially in favor of writing out acronyms, I would agree in this case that DevelopmentOfMathematicalExpressions might be taking it a bit too far. There is a limit at which package names are just "too long".

@glwagner
Copy link

[noblock] Even though I'm potentially in favor of writing out acronyms, I would agree in this case that DevelopmentOfMathematicalExpressions might be taking it a bit too far. There is a limit at which package names are just "too long".

😂 that's fair (I blame the authors of that paper...) But, one can cheat a bit with DevelopmentOfMathExpressions or perhaps the actually nicer ExpressionDeveloper or something.

@goerz
Copy link
Member

goerz commented Oct 18, 2024

I actually also see some value in keeping acronyms in packages names, for recognizability. And, I also believe that "pronounceable" acronyms are perfectly fine as package names. They're basically in the "less systematic names" category, same as "Makie" etc. It's just that this name is particularly short (a.k.a. "nice"), for a package that seems targeted at a pretty small niche.

Did you not like the idea of <Domain>DoME for adding context, including MLDoME and AIDoME? Or something else you can combine with DoME to make the name longer and also more context-specific?

@danielriveroc
Copy link

Thank you for your comments.
The name DoME seemed to be a good choice because it describes the algorithm, it is an easy to pronounce acronym, and it also refers to the dome shapes that this algorithm creates in space to solve the problem. For these reasons, we thought it would be best to keep the package name.
Also, I do not find other packages that implement ML algorithms with the ML prefix/suffix (Flux, Knet, DecisionTree, XGBoost, EvoTrees, SVM), only when it refers to a framework or other library, as in the case of LIBSVM.
Regarding to be targeted at a pretty small niche, we believe it is just the opposite. This algorithm gives results, on average, better than those of the other ML techniques. In the paper we show the results for regression problems, and we are currently preparing a paper in which we show the results for classification problems, improving on the other algorithms. With the publication of this package, we hope to provide the community with this algorithm, which not only improves the results offered by the rest, but also offers as a model mathematical equations that are easily portable to any system. Our idea is, in the future, to adapt this algorithm to other paradigms such as Stream Learning, Reinforcement Learning or Image classification. We believe that these characteristics, together with its ease of use (only one function is needed, as can be seen in the example) can make it a widely downloaded and used package by the ML community.

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Oct 26, 2024
@goerz
Copy link
Member

goerz commented Oct 31, 2024

Closing in favor of #118443

@goerz goerz closed this Oct 31, 2024
@giordano giordano deleted the registrator-dome-b4f4f0b4-v1.0.0-156416c7f8 branch November 9, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants