Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm what log (or parameterization/metric) to use in PriorPose2 #615

Open
Affie opened this issue Aug 19, 2022 · 0 comments
Open

Confirm what log (or parameterization/metric) to use in PriorPose2 #615

Affie opened this issue Aug 19, 2022 · 0 comments

Comments

@Affie
Copy link
Member

Affie commented Aug 19, 2022

# TODO the log here looks wrong (for gradients), consider:
# X = log(p⁻¹ ∘ m)
# X = log(M, ϵ, Manifolds.compose(M, inv(M, p), m))
function (cf::CalcFactor{<:PriorPose2})(
m::ArrayPartition{T, Tuple{SVector{2, T}, SMatrix{2, 2, T, 4}}},
p::ArrayPartition{T, Tuple{SVector{2, T}, SMatrix{2, 2, T, 4}}}) where T<:Real
M = getManifold(Pose2)
Xc = _vee(M, log(M, p, m))
return Xc
end

@Affie Affie added this to the v0.0.x milestone Aug 19, 2022
@dehann dehann changed the title Confirm what log (or parametrisation/metric) to use in PriorPose2 Confirm what log (or parameterization/metric) to use in PriorPose2 Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant