Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small erorrs in docs validate links #270

Closed
wants to merge 95 commits into from
Closed

Small erorrs in docs validate links #270

wants to merge 95 commits into from

Conversation

jaksle
Copy link
Contributor

@jaksle jaksle commented Jan 19, 2024

I've noticed two broken links. This corrects them. Additionally, in the plots in the same sections titles overlap with x labels which makes them unintelligible. But, compiling the same docs on my machine does not replicate this behaviour. I have Plots v1.39.0.

EDIT. I remade this PR, I had problems with synchronising fork to the origin.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4df21a) 95.40% compared to head (c62cfc2) 95.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          20       20           
  Lines        1503     1503           
=======================================
  Hits         1434     1434           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyst
Copy link
Member

alyst commented Jan 23, 2024

Thanks! The changes look straightforward, but there are conflicts with the master. It looks like you still have some mix-ups in the commits of this PR: there are 95 commits, which is a bit too much for 3 changed lines.
I guess the easiest would be if you just create a new branch off the Clustering.jl master and add a single new commit with the fixes to the ref links.
And in general, I think it is a good practice, when working on a PR, to create a new feature branch in your local repository instead of committing directly to the main (master one).

Note that for #257 I've squashed all your commits together (since it was all about adding new code) and force-pushed it (to the PR branch in your repository, which happened to be master), so that the commit history in the Clustering.jl is cleaner.

@alyst
Copy link
Member

alyst commented Jan 23, 2024

BTW, do you have a quick fix for the overlapping titles issue in the quality indices docs?
I guess it is just about increasing the vertical padding/margins of the subplots. Would be nice to have it in this PR.

@jaksle jaksle closed this by deleting the head repository Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants