-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small erorrs in docs validate links #270
Conversation
Co-authored-by: Alexey Stukalov <[email protected]>
Co-authored-by: Alexey Stukalov <[email protected]>
Co-authored-by: Alexey Stukalov <[email protected]>
Co-authored-by: Alexey Stukalov <[email protected]>
Co-authored-by: Alexey Stukalov <[email protected]>
Co-authored-by: Alexey Stukalov <[email protected]>
Co-authored-by: Alexey Stukalov <[email protected]>
Co-authored-by: Alexey Stukalov <[email protected]>
Co-authored-by: Alexey Stukalov <[email protected]>
docs links correction
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 20 20
Lines 1503 1503
=======================================
Hits 1434 1434
Misses 69 69 ☔ View full report in Codecov by Sentry. |
Thanks! The changes look straightforward, but there are conflicts with the master. It looks like you still have some mix-ups in the commits of this PR: there are 95 commits, which is a bit too much for 3 changed lines. Note that for #257 I've squashed all your commits together (since it was all about adding new code) and force-pushed it (to the PR branch in your repository, which happened to be master), so that the commit history in the Clustering.jl is cleaner. |
BTW, do you have a quick fix for the overlapping titles issue in the quality indices docs? |
I've noticed two broken links. This corrects them. Additionally, in the plots in the same sections titles overlap with x labels which makes them unintelligible. But, compiling the same docs on my machine does not replicate this behaviour. I have Plots v1.39.0.
EDIT. I remade this PR, I had problems with synchronising fork to the origin.