-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans for RNG changes? #1509
Comments
In my opinion, these should all be in |
Actually, this is done in Rmath itself, so we should get the same benefit (though it's done via C static variables, which is not thread safe). |
I'd like to second the call for better handling of vector random variate generation. For example, generating Gamma variates requires 2 allocations per variate even when I use Distributions.rand! to pre-allocate the array. For example, the following does over 2 million allocations to allocate 1 million gammas: using Distributions |
Currently, StatsFuns' distribution RNGs such as
rand(Poisson(lambda))
are the de-facto standard. However, they are implemented using the Rmath library. This leads to some issues.Should this be addressed here in StatsFuns, or should this kind of RNG functionality be moved to RNG.jl (when it's more developed) (or its own package build upon RNG.jl)?
Note that this these RNGs were found to be the bottleneck of an performance comparison, which is why I am interested in speeding them up.
The text was updated successfully, but these errors were encountered: