-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relaxed Lasso #58
Comments
I had a quick look through how this is implemented in the R package, and it looks like the logic for the relaxed option sits in the R code, rather than in the core fortran library. So unfortunately it looks like we can't simply access the relaxed option from the core compiled library, instead this R logic would need to be duplicated into the Julia package which is a bigger undertaking. |
I see, That means it’s likely to be faster in the julia version |
Thanks for the great package! |
I think that should be fine, although it might be better to update the code to use a generic sparse matrix instead rather than the custom struct. I'm not too familiar with the internals of the package but it feels like that should be possible? |
Yes, a sparse matrix might be better to save the parameters. Regarding the struct, I think line 90 should be changed to a mutable struct: https://github.com/JuliaStats/GLMNet.jl/blob/master/src/GLMNet.jl |
You may be able to use Setfield.jl or Accessors.jl to easily update the new_path = @set path.betas = new_betas |
Nice, thanks for the tip! |
@AdaemmerP did you have any luck implementing the relaxed Lasso? |
@azev77 Yes, I was able to implement but within a time series framework (https://github.com/AdaemmerP/DetectSparsity/blob/main/CaseStudies/Functions.jl, lines 337 - 501). I also used the Lasso.jl package for it. |
The GLMNet package includes the Relaxed Lasso option, which recent research has shown performs very well.
Would it be possible for GLMNet.jl to allow this?
The text was updated successfully, but these errors were encountered: