Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerances in deserialization #703

Merged
merged 7 commits into from
Aug 8, 2023
Merged

Conversation

palday
Copy link
Member

@palday palday commented Aug 8, 2023

Turns out that floating point is hard. :)

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

@palday palday requested a review from dmbates August 8, 2023 03:59
src/serialization.jl Outdated Show resolved Hide resolved
src/serialization.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (8d71961) 95.68% compared to head (2d58011) 95.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   95.68%   95.72%   +0.03%     
==========================================
  Files          35       35              
  Lines        3225     3226       +1     
==========================================
+ Hits         3086     3088       +2     
+ Misses        139      138       -1     
Flag Coverage Δ
current 95.72% <100.00%> (+0.03%) ⬆️
minimum 95.61% <100.00%> (+0.03%) ⬆️
nightly 95.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/serialization.jl 93.75% <100.00%> (+3.12%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/serialization.jl Outdated Show resolved Hide resolved
Co-authored-by: Douglas Bates <[email protected]>
src/serialization.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@palday palday merged commit 5ade8c4 into main Aug 8, 2023
9 checks passed
@palday palday deleted the pa/serialization_tolerance branch August 8, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants