-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rmsd function asks for the same type of real number. #935
Comments
Looking at the functions in |
Sorry, are you saying it is not correct to change it for code dependencies. For me this should be working thank you. |
Ah sorry, my message wasn't clear. I mean that the issue you observed with function f(x::AbstractVector{T}, y::AbstractVector{T}) where {T<:Number}
# Calculations that don't actually require `x` and `y` to have a common element type
end I think all such cases can be changed to: function f(x::AbstractVector, y::AbstractVector)
# ...
end That is, type parameters for the arrays don't need to be specified at all. Making that change would fix your issue for A bit tangential, and we'd have to check the implementations to make sure this is sound, but we could possibly drop the |
My target variable was an Int32 and Predictions were Float64. Is there a reason for the function to not handle these two real vectors.
maybe you can allow:
where S<:Number, T<:Number
The text was updated successfully, but these errors were encountered: