Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #20

Merged
merged 2 commits into from
Jul 4, 2024
Merged

typo #20

merged 2 commits into from
Jul 4, 2024

Conversation

rimhajal
Copy link
Member

@rimhajal rimhajal commented Jul 3, 2024

sorry this typo is annoying me

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.56%. Comparing base (91d1c9c) to head (ee5c956).

Files Patch % Lines
src/RateTable.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files           4        4           
  Lines         114      114           
=======================================
  Hits           85       85           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrnv
Copy link
Member

lrnv commented Jul 3, 2024

Indeed. But since it is part of the publicly facing interface, changing it is breaking and therefore require an update of the major version of the package (when major is >= 1, or minor if major == 0) according to semver. (version is Major.Minor.Patch) : so we have to move to 0.2.0. Can you doo that in the same PR please ?

Edit: And then of course a) correct the spelling of the function is packages that use it b) bump their version requirements for RateTables.jl to 0.2 and c) publish a minor version of them to take it into account.

@rimhajal rimhajal merged commit df209b2 into main Jul 4, 2024
4 of 5 checks passed
@rimhajal
Copy link
Member Author

rimhajal commented Jul 4, 2024

there are no packages that use this function

@rimhajal rimhajal deleted the available_covariates branch July 4, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants